Page MenuHomePhabricator

Fix a race condition in abc-finalize-block
ClosedPublic

Authored by jasonbcox on Feb 18 2020, 23:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC35929c38f475: Fix a race condition in abc-finalize-block
Summary

abc-finalize-block has a race condition where node may not be synced when its finalized block is checked: https://build.bitcoinabc.org/viewLog.html?buildId=29570&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterUbsan&tab=buildLog&_focus=2214

This patch waits until node is synced before checking. I also took the opportunity to rearrange some of the checks in
this section of the test so that checks on each node are organized together. IMO this is easier to read.

Test Plan

test_runner.py abc-finalize-block a bunch of times

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Feb 18 2020, 23:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 18 2020, 23:24
deadalnix accepted this revision.Feb 18 2020, 23:27
This revision is now accepted and ready to land.Feb 18 2020, 23:27
This revision was automatically updated to reflect the committed changes.