HomePhabricator

Fix a race condition in abc-finalize-block

Description

Fix a race condition in abc-finalize-block

Summary:
abc-finalize-block has a race condition where node may not be synced when its finalized block is checked: https://build.bitcoinabc.org/viewLog.html?buildId=29570&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterUbsan&tab=buildLog&_focus=2214

This patch waits until node is synced before checking. I also took the opportunity to rearrange some of the checks in
this section of the test so that checks on each node are organized together. IMO this is easier to read.

Test Plan: test_runner.py abc-finalize-block a bunch of times

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5304

Details

Provenance
jasonbcoxAuthored on Feb 18 2020, 23:19
deadalnixPushed on Feb 20 2020, 23:40
Reviewer
Restricted Project
Differential Revision
D5304: Fix a race condition in abc-finalize-block
Parents
rSTAGING1c4b1649e462: Merge #12035: [qt] change µBTC to bits
Branches
Unknown
Tags
Unknown