Page MenuHomePhabricator

Fix a race condition in abc-finalize-block
ClosedPublic

Authored by jasonbcox on Feb 18 2020, 23:24.

Details

Summary

abc-finalize-block has a race condition where node may not be synced when its finalized block is checked: https://build.bitcoinabc.org/viewLog.html?buildId=29570&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterUbsan&tab=buildLog&_focus=2214

This patch waits until node is synced before checking. I also took the opportunity to rearrange some of the checks in
this section of the test so that checks on each node are organized together. IMO this is easier to read.

Test Plan

test_runner.py abc-finalize-block a bunch of times

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-finalize-test-race
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9525
Build 16962: Default Diff Build & Tests
Build 16961: arc lint + arc unit