Page MenuHomePhabricator

Mute self assign warning in uint256_tests.cpp
ClosedPublic

Authored by deadalnix on Feb 21 2020, 00:12.

Details

Summary

While it is generaly a bad idea to do so, we want to test that the code behave properly if someone came to do this anyways. So we remove the warning using a noop.

Test Plan
ninja check

Verify that the warnings are gone.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
selfassignwarning
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9533
Build 16976: Default Diff Build & Tests
Build 16975: arc lint + arc unit

Event Timeline

deadalnix retitled this revision from Must self assign warning in uint256_tests.cpp to Mute self assign warning in uint256_tests.cpp.Feb 21 2020, 01:57
jasonbcox added a subscriber: jasonbcox.

Nifty solution.

This revision is now accepted and ready to land.Feb 21 2020, 04:16