Page MenuHomePhabricator
Differential D5334

[CI] Run the cmake build with make as a generator
ClosedPublic
Actions

Authored by Fabien on Feb 26 2020, 13:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf197a1c84735: [CI] Run the cmake build with make as a generator
rABCf197a1c84735: [CI] Run the cmake build with make as a generator
Summary

This would prevent from introducing regressions, since it is clear that
the devs tend to prefer ninja.

Depends on D5333.

Test Plan
export ABC_BUILD_NAME=build-make-generator
../contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_check_make
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9580
Build 17064: Default Diff Build & Tests
Build 17063: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 26 2020, 13:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2020, 13:52
teamcity added a comment.Feb 26 2020, 13:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 26 2020, 14:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9580: Diff 16519.Feb 26 2020, 14:02
deadalnix added a subscriber: deadalnix.Feb 26 2020, 18:01
deadalnix added inline comments.
contrib/teamcity/build-configurations.sh
268

Let's make the bitcoin-bench target part of all.

deadalnix accepted this revision.Feb 26 2020, 18:02
This revision is now accepted and ready to land.Feb 26 2020, 18:02
Fabien updated this revision to Diff 16612.Feb 28 2020, 13:49

Building bitcoin-bench is no longer needed since D5346.

teamcity added a comment.Feb 28 2020, 14:27

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 28 2020, 14:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9635: Diff 16612.Feb 28 2020, 14:38
Closed by commit rABCf197a1c84735: [CI] Run the cmake build with make as a generator (authored by Fabien). · Explain WhyMar 3 2020, 07:40
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf197a1c84735: [CI] Run the cmake build with make as a generator.
Fabien added a commit: rSTAGINGf197a1c84735: [CI] Run the cmake build with make as a generator.Apr 7 2020, 23:12

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
9 lines

Diff 16519

View Options

contrib/teamcity/build-configurations.sh

Loading...