Page MenuHomePhabricator
Differential D5394

[DOC] Update the depends README with dependencies and cmake instructions
ClosedPublic
Actions

Authored by Fabien on Mar 2 2020, 14:44.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING3aaf582f6e7a: [DOC] Update the depends README with dependencies and cmake instructions
rABC3aaf582f6e7a: [DOC] Update the depends README with dependencies and cmake instructions
Summary

This diff updates the cross compilation instructions to use cmake and
ninja.
It also make the doc in sync with core with up to date dependencies.

Backport of core PR14264 and PR16051.

Test Plan

Read and test the instructions.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 2 2020, 14:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 2 2020, 14:44
teamcity edited the summary of this revision. (Show Details)Mar 2 2020, 14:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 2 2020, 14:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 2 2020, 14:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9680: Diff 16682.Mar 2 2020, 14:54
Fabien mentioned this in D5397: [DOC] Various updates to cmake/ninja.Mar 2 2020, 16:11
deadalnix added a subscriber: deadalnix.Mar 2 2020, 23:35
deadalnix added inline comments.
depends/README.md
58 ↗(On Diff #16682)

???

92 ↗(On Diff #16682)

Why change the order?

Fabien planned changes to this revision.Mar 3 2020, 07:13
Fabien added inline comments.
depends/README.md
58 ↗(On Diff #16682)

There is no error, D854 still applies.
I can look into this and try to find an option that remove the dependency, but it's out of scope.

92 ↗(On Diff #16682)

Rebase issue, will fix.

Fabien updated this revision to Diff 16719.Mar 3 2020, 07:16

Fix ordering.

teamcity added a comment.Mar 3 2020, 07:16

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 07:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9698: Diff 16719.Mar 3 2020, 07:26
Fabien mentioned this in rABCe7b7a0be4adf: [DOC] Various updates to cmake/ninja.Mar 3 2020, 07:37
jasonbcox requested changes to this revision.Mar 3 2020, 18:27
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
depends/README.md
97 ↗(On Diff #16719)

This example uses make, but the next line references cmake. Either cleanup the wording for this whole paragraph or just don't reference make at all (use more general wording).

This revision now requires changes to proceed.Mar 3 2020, 18:27
jasonbcox added inline comments.Mar 3 2020, 18:29
depends/README.md
97 ↗(On Diff #16719)

Looks like this may be the make command to build depends, not the ABC build. That could be clarified.

Fabien planned changes to this revision.Mar 3 2020, 20:33
Fabien added inline comments.
depends/README.md
97 ↗(On Diff #16719)

Yes the depends are built using a Makefile. I can probably reword this a bit.

Fabien updated this revision to Diff 16748.Mar 3 2020, 20:47

Clarify make vs cmake.

teamcity added a comment.Mar 3 2020, 20:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 20:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9716: Diff 16748.Mar 3 2020, 20:57
deadalnix accepted this revision.Mar 5 2020, 23:40
jasonbcox accepted this revision.Mar 6 2020, 00:28
This revision is now accepted and ready to land.Mar 6 2020, 00:28
Closed by commit rABC3aaf582f6e7a: [DOC] Update the depends README with dependencies and cmake instructions (authored by Fabien). · Explain WhyMar 6 2020, 13:38
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC3aaf582f6e7a: [DOC] Update the depends README with dependencies and cmake instructions.
Fabien mentioned this in rSTAGINGe7b7a0be4adf: [DOC] Various updates to cmake/ninja.Apr 7 2020, 23:12
Fabien added a commit: rSTAGING3aaf582f6e7a: [DOC] Update the depends README with dependencies and cmake instructions.Apr 7 2020, 23:15

Revision Contents
Changeset List

PathSize
depends/
86 lines
doc/
3 lines

Diff 16803

View Options

depends/README.md

Loading...
View Options

doc/build-unix.md

Loading...