Page MenuHomePhabricator

[DOC] Update the depends README with dependencies and cmake instructions
ClosedPublic

Authored by Fabien on Mar 2 2020, 14:44.

Details

Summary

This diff updates the cross compilation instructions to use cmake and
ninja.
It also make the doc in sync with core with up to date dependencies.

Backport of core PR14264 and PR16051.

Test Plan

Read and test the instructions.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
doc_cmake_depends
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9680
Build 17258: Default Diff Build & Tests
Build 17257: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added inline comments.
depends/README.md
58

???

92

Why change the order?

Fabien planned changes to this revision.Mar 3 2020, 07:13
Fabien added inline comments.
depends/README.md
58

There is no error, D854 still applies.
I can look into this and try to find an option that remove the dependency, but it's out of scope.

92

Rebase issue, will fix.

jasonbcox requested changes to this revision.Mar 3 2020, 18:27
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
depends/README.md
97 ↗(On Diff #16719)

This example uses make, but the next line references cmake. Either cleanup the wording for this whole paragraph or just don't reference make at all (use more general wording).

This revision now requires changes to proceed.Mar 3 2020, 18:27
depends/README.md
97 ↗(On Diff #16719)

Looks like this may be the make command to build depends, not the ABC build. That could be clarified.

Fabien planned changes to this revision.Mar 3 2020, 20:33
Fabien added inline comments.
depends/README.md
97 ↗(On Diff #16719)

Yes the depends are built using a Makefile. I can probably reword this a bit.

This revision is now accepted and ready to land.Mar 6 2020, 00:28