Page MenuHomePhabricator

[SECP256K1] Fix Travis failures due to APT addon
ClosedPublic

Authored by Fabien on Mar 3 2020, 10:54.

Details

Summary

The Travis build sometimes fails with on of these symptoms:

  • The cmake install works as expected, but the version selected by apt

is the one from the ubuntu repository (3.5) instead of the kitware one
(latest). This is the most common issue (see
https://travis-ci.org/Bitcoin-ABC/secp256k1/jobs/656567740).

  • The signing key failed to import (see

https://travis-ci.org/Fabcien/secp256k1/jobs/657636912);

  • The kitware repository cannot be fetched (see

https://travis-ci.org/Fabcien/secp256k1/jobs/657636911).

Since all my attempt to fix these issues failed, this diff avoids
completely the Travis APT addon and proceed the installation in a
script.

It is hard to tell if that fixes the issue since it doesn't happen all
the time, but my previous build had a lot of these errors
(https://travis-ci.org/Fabcien/secp256k1/builds/657636884) and the one
with this fix was green twice in a row
(https://travis-ci.org/Fabcien/secp256k1/builds/657657646 and
https://travis-ci.org/Fabcien/secp256k1/builds/657683100) so at least
it is not making things worse.

Depends on D5407 for the Travis run to succeed.

Test Plan

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_fix_kitware
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9702
Build 17297: Default Diff Build & Tests
Build 17296: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 3 2020, 23:08

It appears that it is not enough, I finally got a failure (PPA timed out) after more than 10 successful runs.
Will land anyway since I have Plan B that builds on top.