[SECP256K1] Enable the OpenSSL tests (and benchmark)
ClosedPublic
Actions

Authored by Fabien on Mar 4 2020, 13:21.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING01f082ebb8fe: [SECP256K1] Enable the OpenSSL tests (and benchmark)
rABC01f082ebb8fe: [SECP256K1] Enable the OpenSSL tests (and benchmark)

Summary

This diff enables building the OpenSSL tests by default with CMake. In
order to get rid of the dependency, the SECP256K1_BUILD_OPENSSL_TESTS
variable can be set to OFF. It will also be disabled if the tests are
disabled.

Test Plan

cmake -GNinja .. -DSECP256K1_BUILD_TEST=OFF
grep SECP256K1_BUILD_OPENSSL_TESTS CMakeCache.txt

Check that SECP256K1_BUILD_OPENSSL_TESTS is not defined in the cache.

cmake -GNinja .. -DSECP256K1_BUILD_OPENSSL_TESTS=OFF
grep SECP256K1_BUILD_OPENSSL_TESTS CMakeCache.txt

Check that SECP256K1_BUILD_OPENSSL_TESTS is disabled in the cache.

cmake -GNinja ..
grep SECP256K1_BUILD_OPENSSL_TESTS CMakeCache.txt

Check that SECP256K1_BUILD_OPENSSL_TESTS is enabled in the cache.

ninja check-secp256k1
ninja bench-secp256k1

Check in the output that the benchmark ecdsa_verify_openssl is run.

Run the Travis build (see
https://travis-ci.org/Fabcien/secp256k1/builds/657808023).

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secp256k1_openssl

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9728
Build 17343: Default Diff Build & Tests
Build 17342: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 4 2020, 13:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 4 2020, 13:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9728: Diff 16766.Mar 4 2020, 13:31

Fabien added a child revision: D5431: [SECP256K1] Request --enable-experimental for the multiset module.Mar 4 2020, 20:39

Fabien added a child revision: D5433: [SECP256K1] Add valgrind check to travis.Mar 5 2020, 09:39

deadalnix requested changes to this revision.Mar 5 2020, 16:54

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/secp256k1/CMakeLists.txt
151	Can you add a message when this fails to explain this is only required for testing and that people can use `-DSECP256K1_BUILD_OPENSSL_TESTS=Off` to disable it? The people who just want to use the lib will not want extra dependencies dumped on them.