Page MenuHomePhabricator
Differential D5435

Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync
ClosedPublic
Actions

Authored by nakihito on Mar 5 2020, 20:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING61fa035c75d7: Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync
rABC61fa035c75d7: Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync
Summary

b0d2ca9fb66d793e3c0f2e6ede811f1b16c33a9f wallet: Exit SyncMetaData if there are no transactions to sync (Wladimir J. van der Laan)

Pull request description:

Instead of crash with an assertion error, simply exit the function `SyncMetaData` if there is no metadata to sync.

Fixes #13110.

Tree-SHA512: 44c4789497b5b63963bef66d8b695987dde80764199f6ea0f2c974be19d29c2663f32446a663a2ee9029e143e5d1d9e8a591e52e6e7e795b982782626bec25bb

Backport of Core PR13265

This skips PR11074 and should avoid the issue found here: https://github.com/bitcoin/bitcoin/issues/13110/

Test Plan
ninja check
./bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13265
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9737
Build 17361: Default Diff Build & Tests
Build 17360: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 5 2020, 20:14
Owners added a reviewer: Restricted Owners Package.Mar 5 2020, 20:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2020, 20:14
teamcity edited the summary of this revision. (Show Details)Mar 5 2020, 20:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 5 2020, 20:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 5 2020, 20:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9737: Diff 16780.Mar 5 2020, 20:25
deadalnix accepted this revision.Mar 5 2020, 23:15
This revision is now accepted and ready to land.Mar 5 2020, 23:15
Closed by commit rABC61fa035c75d7: Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync (authored by nakihito). · Explain WhyMar 5 2020, 23:36
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC61fa035c75d7: Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync.
nakihito added a commit: rSTAGING61fa035c75d7: Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync.Apr 7 2020, 23:14

Revision Contents
Changeset List

PathSize
src/
wallet/
4 lines

Diff 16780

View Options

src/wallet/wallet.cpp

Loading...