Page MenuHomePhabricator
Differential D5458

Adds PeerMessagingState enum to seeder/bitcoin.*
ClosedPublic
Actions

Authored by nakihito on Mar 9 2020, 21:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING411bd9b97e91: Adds PeerMessagingState enum to seeder/bitcoin.*
rABC411bd9b97e91: Adds PeerMessagingState enum to seeder/bitcoin.*
Summary

Moves enum from just the p2p_messaging_tests.cpp to bitcoin.h allowing
use in the rest of the seeder code.

Test Plan
ninja check-bitcoin-seeder

Diff Detail

Repository
rABC Bitcoin ABC
Branch
AddEnumsToSeeder
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9778
Build 17431: Default Diff Build & Tests
Build 17430: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 9 2020, 21:22
Owners added a reviewer: Restricted Owners Package.Mar 9 2020, 21:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 9 2020, 21:22
teamcity added a comment.Mar 9 2020, 21:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9778: Diff 16857.Mar 9 2020, 21:32
teamcity added a comment.Mar 9 2020, 21:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Mar 12 2020, 15:21
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/seeder/bitcoin.h
24

Put the false state first.

This revision is now accepted and ready to land.Mar 12 2020, 15:21
nakihito updated this revision to Diff 16902.Mar 12 2020, 17:57

Put false state first in enum.

teamcity added a comment.Mar 12 2020, 17:57

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 12 2020, 18:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9797: Diff 16902.Mar 12 2020, 18:10
Closed by commit rABC411bd9b97e91: Adds PeerMessagingState enum to seeder/bitcoin.* (authored by nakihito). · Explain WhyMar 12 2020, 19:50
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC411bd9b97e91: Adds PeerMessagingState enum to seeder/bitcoin.*.
nakihito added a commit: rSTAGING411bd9b97e91: Adds PeerMessagingState enum to seeder/bitcoin.*.Apr 7 2020, 23:19

Revision Contents
Changeset List

PathSize
src/
seeder/
8 lines
15 lines
test/
12 lines

Diff 16857

View Options

src/seeder/bitcoin.h

Loading...
View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/seeder/test/p2p_messaging_tests.cpp

Loading...