Page MenuHomePhabricator
Differential D5507

Merge #14411: [wallet] Restore ability to list incoming transactions by label
ClosedPublic
Actions

Authored by nakihito on Mar 18 2020, 20:30.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING1d2c6a4bffa9: Merge #14411: [wallet] Restore ability to list incoming transactions by label
rABC1d2c6a4bffa9: Merge #14411: [wallet] Restore ability to list incoming transactions by label
Summary

da427dbd48 Rename ListTransactions filter variable (Russell Yanofsky)
65b740f92b [wallet] Restore ability to list incoming transactions by label (Russell Yanofsky)

Pull request description:

This change partially reverts #13075 and #14023.

Fixes #14382

Tree-SHA512: 8c4e56104b3a45784cdc06bae8e5facdfff04fe3545b63a35e0ec2e440a41b79d84833ca4c4e728d8af7ebb8a519303a9eda7bee4bbfb92bd50c58587a33eb30

Backport of Core PR14411

Addresses concern raised https://github.com/Bitcoin-ABC/bitcoin-abc/issues/354

Test Plan
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help listtransactions

Verify changes to help text.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 18 2020, 20:30
Owners added a reviewer: Restricted Owners Package.Mar 18 2020, 20:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2020, 20:30
nakihito planned changes to this revision.Mar 18 2020, 20:30
teamcity edited the summary of this revision. (Show Details)Mar 18 2020, 20:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 18 2020, 20:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 18 2020, 20:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9868: Diff 17007.Mar 18 2020, 20:40
nakihito requested review of this revision.Mar 18 2020, 21:04
nakihito edited the summary of this revision. (Show Details)
jasonbcox accepted this revision.Mar 18 2020, 22:17
This revision is now accepted and ready to land.Mar 18 2020, 22:17
Closed by commit rABC1d2c6a4bffa9: Merge #14411: [wallet] Restore ability to list incoming transactions by label (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMar 18 2020, 22:24
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC1d2c6a4bffa9: Merge #14411: [wallet] Restore ability to list incoming transactions by label.
nakihito mentioned this in D5508: Release notes for D5507.Mar 18 2020, 22:38
nakihito mentioned this in rABCdfe55e6bcfef: Release notes for D5507.Mar 18 2020, 23:59
nakihito added a commit: rSTAGING1d2c6a4bffa9: Merge #14411: [wallet] Restore ability to list incoming transactions by label.Apr 7 2020, 23:22
nakihito mentioned this in rSTAGINGdfe55e6bcfef: Release notes for D5507.

Revision Contents
Changeset List

PathSize
src/
wallet/
56 lines
test/
functional/
35 lines
14 lines

Diff 17010

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_import_rescan.py

Loading...
View Options

test/functional/wallet_listtransactions.py

Loading...