Page MenuHomePhabricator

Merge #14411: [wallet] Restore ability to list incoming transactions by label
ClosedPublic

Authored by nakihito on Wed, Mar 18, 20:30.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC1d2c6a4bffa9: Merge #14411: [wallet] Restore ability to list incoming transactions by label
Summary

da427dbd48 Rename ListTransactions filter variable (Russell Yanofsky)
65b740f92b [wallet] Restore ability to list incoming transactions by label (Russell Yanofsky)

Pull request description:

This change partially reverts #13075 and #14023.

Fixes #14382

Tree-SHA512: 8c4e56104b3a45784cdc06bae8e5facdfff04fe3545b63a35e0ec2e440a41b79d84833ca4c4e728d8af7ebb8a519303a9eda7bee4bbfb92bd50c58587a33eb30

Backport of Core PR14411

Addresses concern raised https://github.com/Bitcoin-ABC/bitcoin-abc/issues/354

Test Plan
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help listtransactions

Verify changes to help text.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Wed, Mar 18, 20:30
Owners added a reviewer: Restricted Owners Package.Wed, Mar 18, 20:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 18, 20:30
nakihito planned changes to this revision.Wed, Mar 18, 20:30
teamcity edited the summary of this revision. (Show Details)Wed, Mar 18, 20:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Wed, Mar 18, 21:04
nakihito edited the summary of this revision. (Show Details)
jasonbcox accepted this revision.Wed, Mar 18, 22:17
This revision is now accepted and ready to land.Wed, Mar 18, 22:17