Page MenuHomePhabricator

Merge #14411: [wallet] Restore ability to list incoming transactions by label
ClosedPublic

Authored by nakihito on Mar 18 2020, 20:30.

Details

Summary

da427dbd48 Rename ListTransactions filter variable (Russell Yanofsky)
65b740f92b [wallet] Restore ability to list incoming transactions by label (Russell Yanofsky)

Pull request description:

This change partially reverts #13075 and #14023.

Fixes #14382

Tree-SHA512: 8c4e56104b3a45784cdc06bae8e5facdfff04fe3545b63a35e0ec2e440a41b79d84833ca4c4e728d8af7ebb8a519303a9eda7bee4bbfb92bd50c58587a33eb30

Backport of Core PR14411

Addresses concern raised https://github.com/Bitcoin-ABC/bitcoin-abc/issues/354

Test Plan
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help listtransactions

Verify changes to help text.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14411
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9868
Build 17599: Default Diff Build & Tests
Build 17598: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 18 2020, 20:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 18 2020, 22:17