Page MenuHomePhabricator
Differential D5518

Merge #14208: [build] Actually remove ENABLE_WALLET
ClosedPublic
Actions

Authored by nakihito on Mar 19 2020, 22:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING481ac5a90d78: Merge #14208: [build] Actually remove ENABLE_WALLET
rABC481ac5a90d78: Merge #14208: [build] Actually remove ENABLE_WALLET
Summary

e4ef4b459548b4032b9da03b3103525f935acb82 [build] remove #ifdef ENABLE_WALLET from interfaces/node (John Newbery)

Pull request description:

Adds a couple of redefinitions to dummywallet.cpp.

Tree-SHA512: d226bcccc46d089eac88beb54c31f6f18817682994b371f9793a5d28bec5d60dbdffacc8fc281807e25cc7f89da23e1f8f36fd99d12f8a40f77a972840e8c1b4

Backport of Core PR14208

Test Plan
cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
ninja
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli getnewaddress

Verify rpc fails because there is no wallet.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14208
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9897
Build 17653: Default Diff Build & Tests
Build 17652: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 19 2020, 22:43
Owners added a reviewer: Restricted Owners Package.Mar 19 2020, 22:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2020, 22:43
teamcity edited the summary of this revision. (Show Details)Mar 19 2020, 22:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 19 2020, 22:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 19 2020, 23:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9897: Diff 17061.Mar 19 2020, 23:07
deadalnix requested changes to this revision.Mar 20 2020, 00:19
deadalnix added a subscriber: deadalnix.

The test plan is inadequate.

This revision now requires changes to proceed.Mar 20 2020, 00:19
nakihito edited the test plan for this revision. (Show Details)Mar 20 2020, 00:43
nakihito requested review of this revision.Mar 20 2020, 00:57
nakihito edited the test plan for this revision. (Show Details)

Fixed test plan.

deadalnix accepted this revision.Mar 20 2020, 17:12
This revision is now accepted and ready to land.Mar 20 2020, 17:12
Closed by commit rABC481ac5a90d78: Merge #14208: [build] Actually remove ENABLE_WALLET (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyMar 20 2020, 20:10
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC481ac5a90d78: Merge #14208: [build] Actually remove ENABLE_WALLET.
nakihito added a commit: rSTAGING481ac5a90d78: Merge #14208: [build] Actually remove ENABLE_WALLET.Apr 7 2020, 23:24

Revision Contents
Changeset List

PathSize
src/
16 lines
interfaces/
22 lines
4 lines

Diff 17061

View Options

src/dummywallet.cpp

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/interfaces/wallet.h

Loading...