Page MenuHomePhabricator

Some left overs from PR12490
ClosedPublic

Authored by nakihito on Thu, Mar 19, 23:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING92eafd93e7af: Some left overs from PR12490
rABC92eafd93e7af: Some left overs from PR12490
Summary

Looks like this was partially done in D3978.

Partial backport of Core PR12490

Test Plan
cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
ninja
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli getnewaddress

Verify rpc fails because there is no wallet.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Thu, Mar 19, 23:10
Owners added a reviewer: Restricted Owners Package.Thu, Mar 19, 23:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 19, 23:10
teamcity edited the summary of this revision. (Show Details)Thu, Mar 19, 23:10

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Fri, Mar 20, 17:12
deadalnix added a subscriber: deadalnix.

Test plan is inadequate.

This revision now requires changes to proceed.Fri, Mar 20, 17:12
nakihito requested review of this revision.Fri, Mar 20, 18:04
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

deadalnix accepted this revision.Fri, Mar 20, 19:18
This revision is now accepted and ready to land.Fri, Mar 20, 19:18
This revision was automatically updated to reflect the committed changes.