Some left overs from PR12490
ClosedPublic
Actions

Authored by nakihito on Mar 19 2020, 23:10.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING92eafd93e7af: Some left overs from PR12490
rABC92eafd93e7af: Some left overs from PR12490

Summary

Looks like this was partially done in D3978.

Partial backport of Core PR12490

Test Plan

cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
ninja
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli getnewaddress

Verify rpc fails because there is no wallet.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 19 2020, 23:10

Owners added a reviewer: Restricted Owners Package.Mar 19 2020, 23:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2020, 23:10

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9899: Diff 17063.Mar 19 2020, 23:46

Test plan is inadequate.

This revision now requires changes to proceed.Mar 20 2020, 17:12

Updated test plan.

deadalnix accepted this revision.Mar 20 2020, 19:18

This revision is now accepted and ready to land.Mar 20 2020, 19:18

Closed by commit rABC92eafd93e7af: Some left overs from PR12490 (authored by nakihito). · Explain WhyMar 20 2020, 20:19

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC92eafd93e7af: Some left overs from PR12490.

nakihito added a commit: rSTAGING92eafd93e7af: Some left overs from PR12490.Apr 7 2020, 23:25

Revision Contents
Changeset List

Path

Size

src/

rpc/

misc.cpp

10 lines

rawtransaction.cpp

8 lines

Diff 17079

View Options

src/rpc/misc.cpp