Page MenuHomePhabricator
Differential D5520

Some left overs from PR12490
ClosedPublic
Actions

Authored by nakihito on Mar 19 2020, 23:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING92eafd93e7af: Some left overs from PR12490
rABC92eafd93e7af: Some left overs from PR12490
Summary

Looks like this was partially done in D3978.

Partial backport of Core PR12490

Test Plan
cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
ninja
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli getnewaddress

Verify rpc fails because there is no wallet.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12490
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9899
Build 17657: Default Diff Build & Tests
Build 17656: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 19 2020, 23:10
Owners added a reviewer: Restricted Owners Package.Mar 19 2020, 23:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2020, 23:10
teamcity edited the summary of this revision. (Show Details)Mar 19 2020, 23:10

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 19 2020, 23:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 19 2020, 23:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9899: Diff 17063.Mar 19 2020, 23:46
deadalnix requested changes to this revision.Mar 20 2020, 17:12
deadalnix added a subscriber: deadalnix.

Test plan is inadequate.

This revision now requires changes to proceed.Mar 20 2020, 17:12
nakihito requested review of this revision.Mar 20 2020, 18:04
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

deadalnix accepted this revision.Mar 20 2020, 19:18
This revision is now accepted and ready to land.Mar 20 2020, 19:18
Closed by commit rABC92eafd93e7af: Some left overs from PR12490 (authored by nakihito). · Explain WhyMar 20 2020, 20:19
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC92eafd93e7af: Some left overs from PR12490.
nakihito added a commit: rSTAGING92eafd93e7af: Some left overs from PR12490.Apr 7 2020, 23:25

Revision Contents
Changeset List

PathSize
src/
rpc/
10 lines
8 lines

Diff 17063

View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...