Page MenuHomePhabricator

Merge #14291: wallet: Add ListWalletDir utility function
ClosedPublic

Authored by nakihito on Fri, Mar 20, 21:27.

Details

Summary

d56a0689354fb814510c6c393f3e07ac9362dc1f docs: Add release notes for listwalletdir RPC (João Barbosa)
0cb3cad166bbeb75e9cc1512286453f8e7d4f717 qa: Add tests for listwalletdir RPC (João Barbosa)
cc3377360c417780f5cbd7bd69b438817a9d60be rpc: Add listwalletdir RPC (João Barbosa)
d1b03b8e5f04a2cc9ebb985bd9a1aebd2068f757 interfaces: Add getWalletDir and listWalletDir to Node (João Barbosa)
fc4db35bfd78d85d6b52d5da3d89696160658450 wallet: Add ListWalletDir utility (João Barbosa)

Pull request description:

`ListWalletDir` returns all available wallets in the current wallet directory.

Based on MeshCollider work in pull #11485.

Tree-SHA512: 5843e3dbd1e0449f55bb8ea7c241a536078ff6ffcaad88ce5fcf8963971d48c78600fbc4f44919523b8a92329d5d8a5f567a3e0ccb0270fdd27366e19603a716

Backport of Core PR14291

Test Plan
ninja
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help

Verify listwalletdir appears in the list of Wallet RPCs.

./bitcoin-cli help listwalletdir
./bitcoin-cli listwalletdir

Verify new RPC help text and behavior.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Fri, Mar 20, 21:27
Owners added a reviewer: Restricted Owners Package.Fri, Mar 20, 21:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Mar 20, 21:27
teamcity edited the summary of this revision. (Show Details)Fri, Mar 20, 21:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito added inline comments.Fri, Mar 20, 21:31
src/wallet/walletutil.cpp
7–8 ↗(On Diff #17080)

Ditto.

src/wallet/walletutil.h
8 ↗(On Diff #17080)

This is the equivalent of Core's util.h at the time of the merge request.

nakihito updated this revision to Diff 17081.Fri, Mar 20, 22:19

Fixed some formatting issues.

deadalnix accepted this revision.Sat, Mar 21, 00:20
This revision is now accepted and ready to land.Sat, Mar 21, 00:20