Page MenuHomePhabricator

Add another UBSAN vptr suppression
ClosedPublic

Authored by jasonbcox on Sun, Mar 22, 23:26.

Details

Summary

The recent UBSAN failures ( example: https://build.bitcoinabc.org/viewLog.html?buildId=32136&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterUbsan&tab=buildLog&_focus=2561 ) appear to be triggered by a recent patch ( D5527 ) but I can find no definite root cause within that patch itself. I am able to reproduce this error with clang-8, but tests pass building with clang-9.

Similar to D4848, the exact root cause of this vptr issue is unknown. This patch adds a similar suppression.

Test Plan
ABC_BUILD_NAME=build-ubsan ./contrib/teamcity/build-configurations.sh

export UBSAN_OPTIONS="suppressions=/home/jasonbcox/projects/bitcoin-abc/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1"
./test/functional/test_runner.py wallet_multiwallet

+ UBSAN on CI

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Sun, Mar 22, 23:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Mar 22, 23:26
jasonbcox planned changes to this revision.Sun, Mar 22, 23:26
jasonbcox edited the summary of this revision. (Show Details)Sun, Mar 22, 23:36
jasonbcox edited the test plan for this revision. (Show Details)Sun, Mar 22, 23:42
jasonbcox requested review of this revision.Mon, Mar 23, 00:00
deadalnix accepted this revision.Mon, Mar 23, 01:20
This revision is now accepted and ready to land.Mon, Mar 23, 01:20
This revision was automatically updated to reflect the committed changes.