Paths

Table of Contentst

[UBSAN] Fix UBSAN issue in test_bitcon_main.cpp
ClosedPublic
Actions

Authored by Fabien on Jan 7 2020, 18:10.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING250cdabe9cc4: [UBSAN] Fix UBSAN issue in test_bitcon_main.cpp
rABC250cdabe9cc4: [UBSAN] Fix UBSAN issue in test_bitcon_main.cpp

Summary

This diff fixes an UBSAN issue introduced in D4841:

It moves the master_test_suite_t reference to a variable;
It adds an exception for the root cause of the UBSAN failure

Note that for some reason, this error only occurs with Clang < 9.

Test Plan

Run the build-ubsan configuration on CI.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 7 2020, 18:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2020, 18:10

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Jan 7 2020, 18:14

This revision is now accepted and ready to land.Jan 7 2020, 18:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8770: Diff 15204.Jan 7 2020, 18:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABC250cdabe9cc4: [UBSAN] Fix UBSAN issue in test_bitcon_main.cpp (authored by Fabien). · Explain WhyJan 7 2020, 18:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC250cdabe9cc4: [UBSAN] Fix UBSAN issue in test_bitcon_main.cpp.

jasonbcox mentioned this in D5535: Add another UBSAN vptr suppression.Mar 22 2020, 23:36

jasonbcox mentioned this in rABC3eb3dcb04558: Add another UBSAN vptr suppression.Mar 23 2020, 04:01

Fabien added a commit: rSTAGING250cdabe9cc4: [UBSAN] Fix UBSAN issue in test_bitcon_main.cpp.Apr 7 2020, 22:18

jasonbcox mentioned this in rSTAGING3eb3dcb04558: Add another UBSAN vptr suppression.Apr 7 2020, 23:25

Revision Contents
Changeset List

Path

Size

src/

test/

test_bitcoin_main.cpp

5 lines

test/

sanitizer_suppressions/

ubsan

2 lines

Diff 15205

View Options

src/test/test_bitcoin_main.cpp