Page MenuHomePhabricator

[UBSAN] Fix UBSAN issue in test_bitcon_main.cpp
ClosedPublic

Authored by Fabien on Jan 7 2020, 18:10.

Details

Summary

This diff fixes an UBSAN issue introduced in D4841:

  • It moves the master_test_suite_t reference to a variable;
  • It adds an exception for the root cause of the UBSAN failure

Note that for some reason, this error only occurs with Clang < 9.

Test Plan

Run the build-ubsan configuration on CI.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ubsan_boost_global_fixture
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8770
Build 15522: Default Diff Build & Tests
Build 15521: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 7 2020, 18:14