Page MenuHomePhabricator
Differential D5541

Fix portability issue with pthreads
ClosedPublic
Actions

Authored by Fabien on Mar 23 2020, 15:43.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGbd90ec836099: Fix portability issue with pthreads
rABCbd90ec836099: Fix portability issue with pthreads
Summary

Fixes the build on some *BSD.

Backport of core PR15968.

Depends on D5540 (and D5542 for the test plan).

Test Plan
ninja check

Build on FreeBSD 12.0.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15968
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9933
Build 17725: Default Diff Build & Tests
Build 17724: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 23 2020, 15:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2020, 15:43
teamcity edited the summary of this revision. (Show Details)Mar 23 2020, 15:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 23 2020, 15:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien planned changes to this revision.Mar 23 2020, 15:43
teamcity added a comment.Mar 23 2020, 16:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9931: Diff 17114.Mar 23 2020, 16:07
Fabien edited the summary of this revision. (Show Details)Mar 23 2020, 16:08
Fabien added a parent revision: D5542: [SECP256K1] Disable ASM for native executables.
Fabien updated this revision to Diff 17116.Mar 23 2020, 16:08

Rebase

teamcity added a comment.Mar 23 2020, 16:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 23 2020, 16:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9933: Diff 17116.Mar 23 2020, 16:30
jasonbcox accepted this revision.Mar 23 2020, 17:36
This revision is now accepted and ready to land.Mar 23 2020, 17:36
Closed by commit rABCbd90ec836099: Fix portability issue with pthreads (authored by grim-trigger <36375872+grim-trigger@users.noreply.github.com>, committed by Fabien). · Explain WhyMar 24 2020, 09:40
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCbd90ec836099: Fix portability issue with pthreads.
Fabien added a commit: rSTAGINGbd90ec836099: Fix portability issue with pthreads.Apr 7 2020, 23:26

Revision Contents
Changeset List

PathSize
src/
util/
5 lines

Diff 17116

View Options

src/util/threadnames.cpp

Loading...