Page MenuHomePhabricator

Don't rename main thread at process level
ClosedPublic

Authored by Fabien on Mon, Mar 23, 16:32.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC65e33fdc9e9f: Don't rename main thread at process level
Summary
Set only the internal name.

Fixes #17036 for both `bitcoind` and `bitcoin-qt`.

This fixes Unix tools like ps or pkill that use the process name
(called bitcoin-init since D5540).

Backport of core PR17038.

Depends on D5540.

Test Plan
ninja check

bitcoind -daemon
ps -A | grep bitcoind # should return our bitcoind instance
sudo killall bitcoind
ps -A | grep bitcoind # should return nothing, kill successful

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Mar 23, 16:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Mar 23, 16:32
teamcity edited the summary of this revision. (Show Details)Mon, Mar 23, 16:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Mon, Mar 23, 17:33
This revision is now accepted and ready to land.Mon, Mar 23, 17:33
This revision was automatically updated to reflect the committed changes.