Page MenuHomePhabricator
Differential D5544

Don't rename main thread at process level
ClosedPublic
Actions

Authored by Fabien on Mar 23 2020, 16:32.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING65e33fdc9e9f: Don't rename main thread at process level
rABC65e33fdc9e9f: Don't rename main thread at process level
Summary
Set only the internal name.

Fixes #17036 for both `bitcoind` and `bitcoin-qt`.

This fixes Unix tools like ps or pkill that use the process name
(called bitcoin-init since D5540).

Backport of core PR17038.

Depends on D5540.

Test Plan
ninja check

bitcoind -daemon
ps -A | grep bitcoind # should return our bitcoind instance
sudo killall bitcoind
ps -A | grep bitcoind # should return nothing, kill successful

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR17038
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9935
Build 17729: Default Diff Build & Tests
Build 17728: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 23 2020, 16:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2020, 16:32
teamcity edited the summary of this revision. (Show Details)Mar 23 2020, 16:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 23 2020, 16:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 23 2020, 16:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9935: Diff 17118.Mar 23 2020, 16:44
jasonbcox accepted this revision.Mar 23 2020, 17:33
This revision is now accepted and ready to land.Mar 23 2020, 17:33
Closed by commit rABC65e33fdc9e9f: Don't rename main thread at process level (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by Fabien). · Explain WhyMar 24 2020, 09:42
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC65e33fdc9e9f: Don't rename main thread at process level.
Fabien added a commit: rSTAGING65e33fdc9e9f: Don't rename main thread at process level.Apr 7 2020, 23:26

Revision Contents
Changeset List

PathSize
src/
2 lines
qt/
2 lines
util/
5 lines
4 lines

Diff 17118

View Options

src/bitcoind.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/util/threadnames.h

Loading...
View Options

src/util/threadnames.cpp

Loading...