Page MenuHomePhabricator
Differential D5542

[SECP256K1] Disable ASM for native executables
ClosedPublic
Actions

Authored by Fabien on Mar 23 2020, 16:06.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING479f3d836613: [SECP256K1] Disable ASM for native executables
rABC479f3d836613: [SECP256K1] Disable ASM for native executables
Summary

If the platforms is detected x86_64 and the ASM check fails, the native
executable will fail as well even if -DSECP256K1_USE_ASM=OFF is passed
to cmake. This diff disables the ASM for the native executables and get
rids of the issue.

Got the issue on FreeBSD 12.0.

Test Plan
ninja check

Build on FreeBSD 12.0.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_native_no_asm
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9932
Build 17723: Default Diff Build & Tests
Build 17722: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 23 2020, 16:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2020, 16:06
teamcity added a comment.Mar 23 2020, 16:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien mentioned this in D5541: Fix portability issue with pthreads.Mar 23 2020, 16:08
Fabien added a child revision: D5541: Fix portability issue with pthreads.
teamcity added a comment.Mar 23 2020, 16:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9932: Diff 17115.Mar 23 2020, 16:29
jasonbcox accepted this revision.Mar 23 2020, 17:35
This revision is now accepted and ready to land.Mar 23 2020, 17:35
Closed by commit rABC479f3d836613: [SECP256K1] Disable ASM for native executables (authored by Fabien). · Explain WhyMar 24 2020, 09:31
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC479f3d836613: [SECP256K1] Disable ASM for native executables.
Fabien mentioned this in rABCbd90ec836099: Fix portability issue with pthreads.Mar 24 2020, 09:40
Fabien added a commit: rSTAGING479f3d836613: [SECP256K1] Disable ASM for native executables.Apr 7 2020, 23:26
Fabien mentioned this in rSTAGINGbd90ec836099: Fix portability issue with pthreads.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
1 line

Diff 17115

View Options

src/secp256k1/CMakeLists.txt

Loading...