[test_runner] Use the daemon property directly instead of setDaemon()
ClosedPublic
Actions

Authored by jasonbcox on Mar 26 2020, 22:21.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe248a3311de3: [test_runner] Use the daemon property directly instead of setDaemon()
rABCe248a3311de3: [test_runner] Use the daemon property directly instead of setDaemon()

Summary

setDaemon() is deprecated: https://docs.python.org/3/library/threading.html#threading.Thread.setDaemon

Test Plan

test_runner.py

Ctrl+C can still be used to kill test_runner.py as expected.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Mar 26 2020, 22:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2020, 22:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox added a child revision: D5584: [test_runner] Fix result collector variable shadowing.Mar 26 2020, 22:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9999: Diff 17225.Mar 26 2020, 22:31

nakihito accepted this revision.Mar 26 2020, 22:56

This revision is now accepted and ready to land.Mar 26 2020, 22:56

Closed by commit rABCe248a3311de3: [test_runner] Use the daemon property directly instead of setDaemon() (authored by jasonbcox). · Explain WhyMar 27 2020, 01:12

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCe248a3311de3: [test_runner] Use the daemon property directly instead of setDaemon().

jasonbcox added a commit: rSTAGINGe248a3311de3: [test_runner] Use the daemon property directly instead of setDaemon().Apr 7 2020, 23:29

Revision Contents
Changeset List

Path

Size

test/

functional/

test_runner.py

4 lines

Diff 17238

View Options

test/functional/test_runner.py

[test_runner] Use the daemon property directly instead of setDaemon()ClosedPublicActions