Page MenuHomePhabricator
Differential D5600

[tests] Remove rpc_zmq.py
ClosedPublic
Actions

Authored by Fabien on Mar 30 2020, 10:16.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8a8007128fed: [tests] Remove rpc_zmq.py
rABC8a8007128fed: [tests] Remove rpc_zmq.py
Summary
rpc_zmq.py is racy and fails intermittently. Remove that test file and
move the getzmqnotifications RPC test into interface_zmq.py

Backport of core PR14419.

Before this diff, running interface_zmq and rpc_zmq at the same time
would fail, because they use the same address and port.

Test Plan
./test/functional/test_runner.py interface_zmq

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 30 2020, 10:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 10:16
teamcity edited the summary of this revision. (Show Details)Mar 30 2020, 10:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 30 2020, 10:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 30 2020, 10:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10025: Diff 17270.Mar 30 2020, 10:26
Fabien added a child revision: D5603: [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq.Mar 30 2020, 12:28
deadalnix requested changes to this revision.Mar 30 2020, 14:00
deadalnix added a subscriber: deadalnix.

You actually did not remove the test.

This revision now requires changes to proceed.Mar 30 2020, 14:00
Fabien updated this revision to Diff 17280.Mar 30 2020, 14:14

Actually do what the title claims.

teamcity added a comment.Mar 30 2020, 14:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.Mar 30 2020, 14:26
This revision is now accepted and ready to land.Mar 30 2020, 14:26
teamcity added a comment.Mar 30 2020, 14:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10034: Diff 17280.Mar 30 2020, 14:32
Closed by commit rABC8a8007128fed: [tests] Remove rpc_zmq.py (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyMar 31 2020, 12:11
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8a8007128fed: [tests] Remove rpc_zmq.py.
Fabien added a commit: rSTAGING8a8007128fed: [tests] Remove rpc_zmq.py.Apr 7 2020, 23:32

Revision Contents
Changeset List

PathSize
test/
functional/
17 lines
4 lines

Diff 17306

View Options

test/functional/interface_zmq.py

Loading...
View Options

test/functional/rpc_zmq.py

Loading...
View Options

test/functional/timing.json

Loading...