Page MenuHomePhabricator

[tests] Remove rpc_zmq.py
ClosedPublic

Authored by Fabien on Mar 30 2020, 10:16.

Details

Summary
rpc_zmq.py is racy and fails intermittently. Remove that test file and
move the getzmqnotifications RPC test into interface_zmq.py

Backport of core PR14419.

Before this diff, running interface_zmq and rpc_zmq at the same time
would fail, because they use the same address and port.

Test Plan
./test/functional/test_runner.py interface_zmq

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14419
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10034
Build 17908: Default Diff Build & Tests
Build 17907: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Mar 30 2020, 14:00
deadalnix added a subscriber: deadalnix.

You actually did not remove the test.

This revision now requires changes to proceed.Mar 30 2020, 14:00

Actually do what the title claims.

This revision is now accepted and ready to land.Mar 30 2020, 14:26
This revision was automatically updated to reflect the committed changes.