Page MenuHomePhabricator
Differential D5605

depends: native_protobuf: avoid system zlib
ClosedPublic
Actions

Authored by Fabien on Mar 30 2020, 13:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING752632fd6864: depends: native_protobuf: avoid system zlib
rABC752632fd6864: depends: native_protobuf: avoid system zlib
Summary
I don't believe we use any zlib features in protobufs

Backport of core PR15580.

Test Plan

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15580
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10030
Build 17900: Default Diff Build & Tests
Build 17899: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 30 2020, 13:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 13:32
teamcity edited the summary of this revision. (Show Details)Mar 30 2020, 13:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 30 2020, 13:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 30 2020, 13:35

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

teamcity added a comment.Mar 30 2020, 13:35

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

teamcity added a comment.Mar 30 2020, 13:35

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.Mar 30 2020, 13:39

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

teamcity added a comment.Mar 30 2020, 13:41

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10030: Diff 17275.Mar 30 2020, 13:41
teamcity added a comment.Mar 30 2020, 13:53

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

teamcity added a comment.Mar 30 2020, 14:06

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

deadalnix accepted this revision.Mar 30 2020, 14:07
This revision is now accepted and ready to land.Mar 30 2020, 14:07
Closed by commit rABC752632fd6864: depends: native_protobuf: avoid system zlib (authored by Carl Dong <accounts@carldong.me>, committed by Fabien). · Explain WhyMar 31 2020, 12:18
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC752632fd6864: depends: native_protobuf: avoid system zlib.
Fabien added a commit: rSTAGING752632fd6864: depends: native_protobuf: avoid system zlib.Apr 7 2020, 23:32

Revision Contents
Changeset List

PathSize
depends/
packages/
2 lines

Diff 17275

View Options

depends/packages/native_protobuf.mk

Loading...