Rebuild native executable when changes to the build system are made
ClosedPublic
Actions

Authored by deadalnix on Mar 31 2020, 18:19.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING26dc0c3112bc: Rebuild native executable when changes to the build system are made
rABC26dc0c3112bc: Rebuild native executable when changes to the build system are made

Summary

When the build rules needs to be updated, cmake isn't always rerun for the native build.

This adds a dependency file that ensures it does. This feature is limited to cmake, so there are no changes with other build systems and a call to clean might still be necessary.

Test Plan

ninja
ninja # Check native build isn't ran again.
touch build.ninja
ninja # Native build runs again.

Build with make as a generator and verify it's still good.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Mar 31 2020, 18:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 31 2020, 18:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Always generate the dep file. It doesn't hurt on other targets and makes things simpler.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10058: Diff 17328.Mar 31 2020, 18:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10059: Diff 17329.Mar 31 2020, 18:35

deadalnix added a child revision: D5628: Use ninja to generate dep files for the native build.Mar 31 2020, 19:23

Fabien accepted this revision.Apr 1 2020, 07:44

This revision is now accepted and ready to land.Apr 1 2020, 07:44

Closed by commit rABC26dc0c3112bc: Rebuild native executable when changes to the build system are made (authored by deadalnix). · Explain WhyApr 1 2020, 12:35

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC26dc0c3112bc: Rebuild native executable when changes to the build system are made.

deadalnix added a commit: rSTAGING26dc0c3112bc: Rebuild native executable when changes to the build system are made.Apr 7 2020, 23:34

Revision Contents
Changeset List

Path

Size

cmake/

modules/

NativeExecutable.cmake

8 lines

templates/

NativeCmakeRunner.cmake.in

2 lines

Diff 17350

View Options

cmake/modules/NativeExecutable.cmake