Page MenuHomePhabricator

build: make building protobuf optional in depends
ClosedPublic

Authored by Fabien on Apr 1 2020, 16:21.

Details

Summary

Backport of core PR16871.

The logic is reversed wrt core since we enable bip70 by default.

Depends on D5637.

Test Plan
make build-osx NO_PROTOBUF=1

Check that protobuf is not built.

../configure --prefix=$PWD/../depends/x86_64-apple-darwin16

Check in the summary that bip70 is disabled:

with bip70  = no

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Apr 1 2020, 16:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2020, 16:21
teamcity edited the summary of this revision. (Show Details)Apr 1 2020, 16:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Apr 1 2020, 16:43
This revision is now accepted and ready to land.Apr 1 2020, 16:43
This revision was automatically updated to reflect the committed changes.