Page MenuHomePhabricator
Differential D5640

build: make building protobuf optional in depends
ClosedPublic
Actions

Authored by Fabien on Apr 1 2020, 16:21.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf1bf3559815e: build: make building protobuf optional in depends
rABCf1bf3559815e: build: make building protobuf optional in depends
Summary

Backport of core PR16871.

The logic is reversed wrt core since we enable bip70 by default.

Depends on D5637.

Test Plan
make build-osx NO_PROTOBUF=1

Check that protobuf is not built.

../configure --prefix=$PWD/../depends/x86_64-apple-darwin16

Check in the summary that bip70 is disabled:

with bip70  = no

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16871
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10080
Build 17993: Default Diff Build & Tests
Build 17992: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 1 2020, 16:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2020, 16:21
teamcity edited the summary of this revision. (Show Details)Apr 1 2020, 16:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 1 2020, 16:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 1 2020, 16:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10080: Diff 17359.Apr 1 2020, 16:35
deadalnix accepted this revision.Apr 1 2020, 16:43
This revision is now accepted and ready to land.Apr 1 2020, 16:43
Closed by commit rABCf1bf3559815e: build: make building protobuf optional in depends (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyApr 2 2020, 09:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf1bf3559815e: build: make building protobuf optional in depends.
Fabien added a commit: rSTAGINGf1bf3559815e: build: make building protobuf optional in depends.Apr 7 2020, 23:35

Revision Contents
Changeset List

PathSize
depends/
8 lines
1 line
4 lines
packages/
6 lines
doc/
2 lines

Diff 17359

View Options

depends/Makefile

Loading...
View Options

depends/README.md

Loading...
View Options

depends/config.site.in

Loading...
View Options

depends/packages/packages.mk

Loading...
View Options

doc/build-unix.md

Loading...