Page MenuHomePhabricator

build: remove redundant sed patching
ClosedPublic

Authored by Fabien on Apr 2 2020, 12:36.

Details

Summary
While looking at #16838 I found at least two cases of sed patching in
depends that now seems to be redundant. There's possibly a third case,
but I haven't looked into that enough yet.

Patching 0 -> kCGMouseButtonLeft should not be required, as
kCGMouseButtonLeft has been used in the cocoa/qcocoacursor.mm source for
a while.

The include we were modifying in
src/plugins/platforms/xcb/qxcbxsettings.cpp was removed in this commit.

Backport of core PR16879.

Test Plan

Run the Linux and OSX Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien planned changes to this revision.Apr 2 2020, 12:37
Fabien requested review of this revision.Apr 2 2020, 13:23
This revision is now accepted and ready to land.Apr 2 2020, 16:47
This revision was automatically updated to reflect the committed changes.