Differential D5657

depends: qt: Fix C{,XX} pickup
ClosedPublic
Actions

Authored by Fabien on Apr 2 2020, 15:35.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGb86752d6fbfc: depends: qt: Fix C{,XX} pickup
rABCb86752d6fbfc: depends: qt: Fix C{,XX} pickup

Summary

QT LOVES to do things its own way and simply ignore all environment
variables. Even listing QMAKE_CC=... in ./configure flags does't work
reliably. This is why we gotta literally edit their config files for
them. Thanks QT.

Backport of core PR17466.

Depends on D5656.

Test Plan

Run the OSX Gitian build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 2 2020, 15:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 2 2020, 15:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10099: Diff 17393.Apr 2 2020, 15:48

It has a change with toolchain.prf that is missing.

This revision now requires changes to proceed.Apr 2 2020, 16:44

This PR is not touching the toolchain.prf line. For reference it is introduced to support the RISC-V architecture.
While I find it really cool I have no hardware to test this so I skipped this backport.

deadalnix accepted this revision.Apr 2 2020, 17:40

This revision is now accepted and ready to land.Apr 2 2020, 17:40

Closed by commit rABCb86752d6fbfc: depends: qt: Fix C{,XX} pickup (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyApr 3 2020, 07:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb86752d6fbfc: depends: qt: Fix C{,XX} pickup.

Fabien added a commit: rSTAGINGb86752d6fbfc: depends: qt: Fix C{,XX} pickup.Apr 7 2020, 23:37