Page MenuHomePhabricator
Differential D5665

build: don't embed a build-id when building libdmg-hfsplus
ClosedPublic
Actions

Authored by Fabien on Apr 3 2020, 08:21.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGb83925969dad: build: don't embed a build-id when building libdmg-hfsplus
rABCb83925969dad: build: don't embed a build-id when building libdmg-hfsplus
Summary
There was a reproducibility issue (IRC logs) with the osx 0.19.1rc1
gitian builds. The build-id embedded into the dmg tool was mismatching.
It's possible that differing versions of binutils/ld were the cause.

While it was resolved after rebuilding the base gitian image, whether an
upstream package issue or fluke, we can remove the possibility of it
happening in future by just not embedding a build-id into the dmg tool
at all.

Backport of core PR18004.

Test Plan

Run the Gitian OSX build twice and check the build is deterministic.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 3 2020, 08:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 3 2020, 08:21
teamcity edited the summary of this revision. (Show Details)Apr 3 2020, 08:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien planned changes to this revision.Apr 3 2020, 08:21

Pending Gitian builds.

teamcity added a comment.Apr 3 2020, 08:23

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

teamcity added a comment.Apr 3 2020, 08:35

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

teamcity added a comment.Apr 3 2020, 08:35

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

teamcity added a comment.Apr 3 2020, 08:46

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

Fabien requested review of this revision.Apr 3 2020, 09:39

The hashes match.

teamcity added a comment.Apr 3 2020, 09:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 3 2020, 10:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10116: Diff 17429.Apr 3 2020, 10:11
deadalnix accepted this revision.Apr 3 2020, 13:19
This revision is now accepted and ready to land.Apr 3 2020, 13:19
Closed by commit rABCb83925969dad: build: don't embed a build-id when building libdmg-hfsplus (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyApr 3 2020, 15:50
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb83925969dad: build: don't embed a build-id when building libdmg-hfsplus.
Fabien added a commit: rSTAGINGb83925969dad: build: don't embed a build-id when building libdmg-hfsplus.Apr 7 2020, 23:37

Revision Contents
Changeset List

PathSize
depends/
packages/
2 lines

Diff 17440

View Options

depends/packages/native_libdmg-hfsplus.mk

Loading...