HomePhabricator

build: don't embed a build-id when building libdmg-hfsplus

Description

build: don't embed a build-id when building libdmg-hfsplus

Summary:

There was a reproducibility issue (IRC logs) with the osx 0.19.1rc1
gitian builds. The build-id embedded into the dmg tool was mismatching.
It's possible that differing versions of binutils/ld were the cause.

While it was resolved after rebuilding the base gitian image, whether an
upstream package issue or fluke, we can remove the possibility of it
happening in future by just not embedding a build-id into the dmg tool
at all.

Backport of core PR18004.

Test Plan: Run the Gitian OSX build twice and check the build is deterministic.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5665

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Jan 26 2020, 04:16
FabienCommitted on Apr 3 2020, 15:50
deadalnixPushed on Apr 3 2020, 21:36
Reviewer
Restricted Project
Differential Revision
D5665: build: don't embed a build-id when building libdmg-hfsplus
Parents
rSTAGING860c08740106: depends: add ability to skip building qrencode
Branches
Unknown
Tags
Unknown