Page MenuHomePhabricator

Remove uses of chainActive and mapBlockIndex in wallet code
ClosedPublic

Authored by Fabien on Apr 8 2020, 13:06.

Details

Summary
This change removes uses of chainActive and mapBlockIndex globals in
wallet code. It is a refactoring change which does not affect external
behavior.

Backport of core PR14711.

Test Plan
ninja all check-extended

Ran the tests with UBSAN and ASAN as well.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Note to reviewers:
This diff is beefy, because splitting by commits will not build and/or fail the tests, and splitting it differently will make it even more difficult to review.

This revision is now accepted and ready to land.Apr 9 2020, 16:47