Page MenuHomePhabricator
Differential D5683

Remove uses of chainActive and mapBlockIndex in wallet code
ClosedPublic
Actions

Authored by Fabien on Apr 8 2020, 13:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING28b138c1a9ba: Remove uses of chainActive and mapBlockIndex in wallet code
rABC28b138c1a9ba: Remove uses of chainActive and mapBlockIndex in wallet code
Summary
This change removes uses of chainActive and mapBlockIndex globals in
wallet code. It is a refactoring change which does not affect external
behavior.

Backport of core PR14711.

Test Plan
ninja all check-extended

Ran the tests with UBSAN and ASAN as well.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14711
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10145
Build 18116: Default Diff Build & Tests
Build 18115: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 8 2020, 13:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2020, 13:06
teamcity edited the summary of this revision. (Show Details)Apr 8 2020, 13:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added a comment.Apr 8 2020, 13:11

Note to reviewers:
This diff is beefy, because splitting by commits will not build and/or fail the tests, and splitting it differently will make it even more difficult to review.

teamcity added a comment.Apr 8 2020, 13:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 8 2020, 13:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10145: Diff 18691.Apr 8 2020, 13:29
deadalnix accepted this revision.Apr 9 2020, 16:47
This revision is now accepted and ready to land.Apr 9 2020, 16:47
Closed by commit rABC28b138c1a9ba: Remove uses of chainActive and mapBlockIndex in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyApr 10 2020, 09:59
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC28b138c1a9ba: Remove uses of chainActive and mapBlockIndex in wallet code.
Fabien added a commit: rSTAGING28b138c1a9ba: Remove uses of chainActive and mapBlockIndex in wallet code.May 5 2020, 18:55
majcosta mentioned this in T600: Backport Core PR 14711: Refactor: Start to separate wallet from node.Aug 5 2021, 00:13

Revision Contents
Changeset List

PathSize
src/
1 line
interfaces/
93 lines
148 lines
13 lines
16 lines
qt/
test/
14 lines
wallet/
31 lines
103 lines
test/
78 lines
38 lines
288 lines

Diff 18691

View Options

src/Makefile.am

Loading...
View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/optional.h

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...