Page MenuHomePhabricator
Differential D5690

Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes.
ClosedPublic
Actions

Authored by jasonbcox on Apr 9 2020, 17:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING150e11f7cea7: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded…
rABC150e11f7cea7: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded…
Summary

eea02be70e Add locking annotation for vNodes. vNodes is guarded by cs_vNodes. (practicalswift)

Pull request description:

Add locking annotation for `vNodes`. `vNodes` is guarded by `cs_vNodes`.

Tree-SHA512: b1e18be22ba5b9dd153536380321b09b30a75a20575f975af9af94164f51982b32267ba0994e77c801513b59da05d923a974a9d2dfebdac48024c4bda98b53af

Backport of Core PR15201

Test Plan
cmake -GNinja -DENABLE_WERROR=ON -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ..
ninja check check-functional

abc-p2p-avalanche is still failing for now, while the investigation continues

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Apr 9 2020, 17:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 9 2020, 17:24
teamcity added a comment.Apr 9 2020, 17:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox edited the summary of this revision. (Show Details)Apr 9 2020, 17:24
teamcity added a comment.Apr 9 2020, 17:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10154: Diff 18707.Apr 9 2020, 17:36
deadalnix requested changes to this revision.Apr 9 2020, 18:12
deadalnix added a subscriber: deadalnix.

Test plan is not adequate.

This revision now requires changes to proceed.Apr 9 2020, 18:12
jasonbcox edited the test plan for this revision. (Show Details)Apr 9 2020, 18:59
jasonbcox requested review of this revision.Apr 9 2020, 19:04

I often forget that... Fixed.

deadalnix accepted this revision.Apr 9 2020, 20:52
This revision is now accepted and ready to land.Apr 9 2020, 20:52
jasonbcox updated this revision to Diff 18729.Apr 10 2020, 15:53

Rebase

teamcity added a comment.Apr 10 2020, 15:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 10 2020, 16:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10168: Diff 18729.Apr 10 2020, 16:08
teamcity added a comment.Apr 10 2020, 16:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-asan) started.

teamcity added a comment.Apr 10 2020, 16:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-asan) passed.

Closed by commit rABC150e11f7cea7: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded… (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyApr 10 2020, 16:35
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC150e11f7cea7: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded….
jasonbcox added a commit: rSTAGING150e11f7cea7: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded….May 5 2020, 18:55

Revision Contents
Changeset List

PathSize
src/
18 lines

Diff 18730

View Options

src/net.h

Loading...