Page MenuHomePhabricator

Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes.
ClosedPublic

Authored by jasonbcox on Apr 9 2020, 17:24.

Details

Summary

eea02be70e Add locking annotation for vNodes. vNodes is guarded by cs_vNodes. (practicalswift)

Pull request description:

Add locking annotation for `vNodes`. `vNodes` is guarded by `cs_vNodes`.

Tree-SHA512: b1e18be22ba5b9dd153536380321b09b30a75a20575f975af9af94164f51982b32267ba0994e77c801513b59da05d923a974a9d2dfebdac48024c4bda98b53af

Backport of Core PR15201

Test Plan
cmake -GNinja -DENABLE_WERROR=ON -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ..
ninja check check-functional

abc-p2p-avalanche is still failing for now, while the investigation continues

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15201
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10168
Build 18162: Default Diff Build & Tests
Build 18161: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Apr 9 2020, 18:12
deadalnix added a subscriber: deadalnix.

Test plan is not adequate.

This revision now requires changes to proceed.Apr 9 2020, 18:12

I often forget that... Fixed.

This revision is now accepted and ready to land.Apr 9 2020, 20:52