Page MenuHomePhabricator
Differential D5699

[backport] test: Fix AreInputsStandard test to reference the proper scriptPubKey
ClosedPublic
Actions

Authored by majcosta on Apr 10 2020, 17:16.

Details

Reviewers
nakihito
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf04619aba422: [backport] test: Fix AreInputsStandard test to reference the proper scriptPubKey
rABCf04619aba422: [backport] test: Fix AreInputsStandard test to reference the proper scriptPubKey
Summary

f95989b3ed Fix AreInputsStandard test to reference the proper scriptPubKey (Ben Woosley)

Pull request description:

This value doesn't affect the outcome of the test, because the values are
properly set on line 351 (https://github.com/bitcoin/bitcoin/pull/13565/files#diff-b7061098b41bd31ef5db043705441133R351), but this makes the test values internally coherent.

This is a backport of Core PR13565

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 10 2020, 17:16
Owners added a reviewer: Restricted Owners Package.Apr 10 2020, 17:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2020, 17:16
teamcity edited the summary of this revision. (Show Details)Apr 10 2020, 17:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 10 2020, 17:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta planned changes to this revision.Apr 10 2020, 17:23
majcosta requested review of this revision.
teamcity added a comment.Apr 10 2020, 17:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10171: Diff 18734.Apr 10 2020, 17:28
nakihito accepted this revision.Apr 10 2020, 17:33
deadalnix accepted this revision.Apr 10 2020, 21:50
This revision is now accepted and ready to land.Apr 10 2020, 21:50
Closed by commit rABCf04619aba422: [backport] test: Fix AreInputsStandard test to reference the proper scriptPubKey (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyApr 10 2020, 21:56
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCf04619aba422: [backport] test: Fix AreInputsStandard test to reference the proper scriptPubKey.
majcosta added a commit: rSTAGINGf04619aba422: [backport] test: Fix AreInputsStandard test to reference the proper scriptPubKey.May 5 2020, 18:55

Revision Contents
Changeset List

PathSize
src/
test/
2 lines

Diff 18736

View Options

src/test/script_p2sh_tests.cpp

Loading...