Page MenuHomePhabricator
Differential D5700

Pass abc RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 10 2020, 17:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING578deeb08e19: Pass abc RPC argument descriptions to RPCHelpMan
rABC578deeb08e19: Pass abc RPC argument descriptions to RPCHelpMan
Summary

This tree in favor of D5571.

Partial backport of Core PR14796

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs abcPatched
./checkrpc.sh RPCs master abcPatched D5700diff

Verify the changes in D5700diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

D5700diff:

D5700diff652 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 10 2020, 17:36
Owners added a reviewer: Restricted Owners Package.Apr 10 2020, 17:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2020, 17:36
nakihito planned changes to this revision.Apr 10 2020, 17:36
teamcity edited the summary of this revision. (Show Details)Apr 10 2020, 17:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 10 2020, 17:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito mentioned this in D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.Apr 10 2020, 17:37
teamcity added a comment.Apr 10 2020, 17:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10172: Diff 18735.Apr 10 2020, 17:47
nakihito edited the test plan for this revision. (Show Details)Apr 10 2020, 18:13
nakihito requested review of this revision.Apr 10 2020, 18:22
deadalnix requested changes to this revision.Apr 10 2020, 22:13
deadalnix added a subscriber: deadalnix.

Some cosmetic changes, but it looks better.

src/rpc/util.h
84 ↗(On Diff #18735)

Why is this here rather than with other members? Please don't put it int he middle of constructors declarations.

This revision now requires changes to proceed.Apr 10 2020, 22:13
nakihito updated this revision to Diff 18740.Apr 11 2020, 00:57

Moved member variable with others.

teamcity added a comment.Apr 11 2020, 00:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10174: Diff 18740.Apr 11 2020, 01:10
teamcity added a comment.Apr 11 2020, 01:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix accepted this revision.Apr 12 2020, 01:29
This revision is now accepted and ready to land.Apr 12 2020, 01:29
Closed by commit rABC578deeb08e19: Pass abc RPC argument descriptions to RPCHelpMan (authored by nakihito). · Explain WhyApr 13 2020, 17:28
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC578deeb08e19: Pass abc RPC argument descriptions to RPCHelpMan.
nakihito added a commit: rSTAGING578deeb08e19: Pass abc RPC argument descriptions to RPCHelpMan.May 5 2020, 18:56

Revision Contents
Changeset List

PathSize
src/
rpc/
14 lines
56 lines
340 lines

Diff 18764

View Options

src/rpc/abc.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...