Page MenuHomePhabricator
Differential D5710

Pass rpc/server RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 13 2020, 17:37.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf7eb5edff8aa: Pass rpc/server RPC argument descriptions to RPCHelpMan
rABCf7eb5edff8aa: Pass rpc/server RPC argument descriptions to RPCHelpMan
Summary

Partial backport of Core PR14796

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched D5710diff

Verify there is no D5710diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14796-server
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10195
Build 18215: Default Diff Build & Tests
Build 18214: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 13 2020, 17:37
Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 17:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 17:37
nakihito planned changes to this revision.Apr 13 2020, 17:37
teamcity edited the summary of this revision. (Show Details)Apr 13 2020, 17:37

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 13 2020, 17:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 13 2020, 17:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10192: Diff 18766.Apr 13 2020, 17:56
nakihito updated this revision to Diff 18771.Apr 13 2020, 18:01

Forgot to rebase for ToString() -> ToStringWithArgs().

teamcity added a comment.Apr 13 2020, 18:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito planned changes to this revision.Apr 13 2020, 18:01
nakihito edited the test plan for this revision. (Show Details)Apr 13 2020, 18:09
teamcity added a comment.Apr 13 2020, 18:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10195: Diff 18771.Apr 13 2020, 18:11
nakihito requested review of this revision.Apr 13 2020, 22:50
nakihito edited the test plan for this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
nakihito added a child revision: D5726: Complete PR14796 by cleaning up some old functions and names.Apr 14 2020, 00:20
jasonbcox accepted this revision.Apr 14 2020, 00:34
This revision is now accepted and ready to land.Apr 14 2020, 00:34
nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 00:35
Closed by commit rABCf7eb5edff8aa: Pass rpc/server RPC argument descriptions to RPCHelpMan (authored by nakihito). · Explain WhyApr 14 2020, 18:38
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCf7eb5edff8aa: Pass rpc/server RPC argument descriptions to RPCHelpMan.
nakihito added a commit: rSTAGINGf7eb5edff8aa: Pass rpc/server RPC argument descriptions to RPCHelpMan.May 5 2020, 18:57

Revision Contents
Changeset List

PathSize
src/
rpc/
13 lines

Diff 18771

View Options

src/rpc/server.cpp

Loading...