Pass rpc/net RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 13 2020, 17:54.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING3413afd1ce58: Pass rpc/net RPC argument descriptions to RPCHelpMan
rABC3413afd1ce58: Pass rpc/net RPC argument descriptions to RPCHelpMan

Summary

Partial backport of Core PR14796

Test Plan

mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched D5712diff

Verify the changes in D5712diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

D5712diff:

D5712diff2 KBDownload

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14796-net

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10194
Build 18213: Default Diff Build & Tests
Build 18212: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 13 2020, 17:54

Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 17:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 17:54

nakihito planned changes to this revision.Apr 13 2020, 17:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10194: Diff 18768.Apr 13 2020, 18:05

nakihito edited the test plan for this revision. (Show Details)Apr 13 2020, 18:08

nakihito edited the test plan for this revision. (Show Details)Apr 13 2020, 23:07

nakihito requested review of this revision.Apr 13 2020, 23:16

nakihito added a child revision: D5726: Complete PR14796 by cleaning up some old functions and names.Apr 14 2020, 00:20

nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 00:36

Fabien accepted this revision.Apr 14 2020, 11:33

This revision is now accepted and ready to land.Apr 14 2020, 11:33

Closed by commit rABC3413afd1ce58: Pass rpc/net RPC argument descriptions to RPCHelpMan (authored by nakihito). · Explain WhyApr 14 2020, 18:45

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC3413afd1ce58: Pass rpc/net RPC argument descriptions to RPCHelpMan.

nakihito added a commit: rSTAGING3413afd1ce58: Pass rpc/net RPC argument descriptions to RPCHelpMan.May 5 2020, 18:57

Revision Contents
Changeset List

Path

Size

src/

rpc/

net.cpp

138 lines

Diff 18768

View Options

Pass rpc/net RPC argument descriptions to RPCHelpManClosedPublicActions