Page MenuHomePhabricator
Differential D5716

Pass rpc/blockchain RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 13 2020, 19:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGb17d1db1baaf: Pass rpc/blockchain RPC argument descriptions to RPCHelpMan
rABCb17d1db1baaf: Pass rpc/blockchain RPC argument descriptions to RPCHelpMan
Summary

Partial backport of Core PR14796

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched D5716diff

Verify the changes in D5716diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

D5716diff:

D5716diff4 KBDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14796-blockchain
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10199
Build 18223: Default Diff Build & Tests
Build 18222: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 13 2020, 19:06
Owners added a reviewer: Restricted Owners Package.Apr 13 2020, 19:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2020, 19:06
nakihito planned changes to this revision.Apr 13 2020, 19:07
teamcity edited the summary of this revision. (Show Details)Apr 13 2020, 19:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 13 2020, 19:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 13 2020, 19:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10199: Diff 18775.Apr 13 2020, 19:18
nakihito edited the test plan for this revision. (Show Details)Apr 13 2020, 23:09
nakihito requested review of this revision.Apr 13 2020, 23:14
nakihito mentioned this in D5726: Complete PR14796 by cleaning up some old functions and names.Apr 14 2020, 00:20
nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 00:37
Fabien accepted this revision.Apr 14 2020, 12:10
This revision is now accepted and ready to land.Apr 14 2020, 12:10
Closed by commit rABCb17d1db1baaf: Pass rpc/blockchain RPC argument descriptions to RPCHelpMan (authored by nakihito). · Explain WhyApr 14 2020, 18:52
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCb17d1db1baaf: Pass rpc/blockchain RPC argument descriptions to RPCHelpMan.
nakihito mentioned this in rABC02ab89366a5a: Complete PR14796 by cleaning up some old functions and names.Apr 15 2020, 22:28
nakihito added a commit: rSTAGINGb17d1db1baaf: Pass rpc/blockchain RPC argument descriptions to RPCHelpMan.May 5 2020, 18:57
nakihito mentioned this in rSTAGING02ab89366a5a: Complete PR14796 by cleaning up some old functions and names.

Revision Contents
Changeset List

PathSize
src/
rpc/
489 lines

Diff 18775

View Options

src/rpc/blockchain.cpp

Loading...