Page MenuHomePhabricator
Differential D5736

Add pf_invalid arg to std::string DecodeBase{32,64}
ClosedPublic
Actions

Authored by Fabien on Apr 15 2020, 11:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8e37f88fcb4e: Add pf_invalid arg to std::string DecodeBase{32,64}
rABC8e37f88fcb4e: Add pf_invalid arg to std::string DecodeBase{32,64}
Summary
Add support for the optional "pf_invalid" out parameter (which allows
the caller to detect decoding failures) to the std::string versions of
DecodeBase32 and DecodeBase64. The char* versions already have this
feature.

Also, rename all uses of pfInvalid to pf_invalid to match style
guidelines.

Partial backport of core PR14978:
https://github.com/bitcoin/bitcoin/pull/14978/commits/162ffefd2f562169725559906601c25c579aa91c

Depends on D5735.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 15 2020, 11:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2020, 11:25
teamcity edited the summary of this revision. (Show Details)Apr 15 2020, 11:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 15 2020, 11:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 15 2020, 11:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10228: Diff 18823.Apr 15 2020, 11:43
Fabien added a child revision: D5737: Split DecodePSBT into Base64 and Raw versions.Apr 15 2020, 11:44
deadalnix accepted this revision.Apr 15 2020, 15:48
This revision is now accepted and ready to land.Apr 15 2020, 15:48
Closed by commit rABC8e37f88fcb4e: Add pf_invalid arg to std::string DecodeBase{32,64} (authored by Glenn Willen <gwillen@nerdnet.org>, committed by Fabien). · Explain WhyApr 16 2020, 13:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8e37f88fcb4e: Add pf_invalid arg to std::string DecodeBase{32,64}.
Fabien added a commit: rSTAGING8e37f88fcb4e: Add pf_invalid arg to std::string DecodeBase{32,64}.May 5 2020, 18:59

Revision Contents
Changeset List

PathSize
src/
util/
8 lines
20 lines

Diff 18860

View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...