Page MenuHomePhabricator

Split DecodePSBT into Base64 and Raw versions
ClosedPublic

Authored by Fabien on Apr 15 2020, 11:44.

Details

Summary
Split up DecodePSBT, which both decodes base64 and then deserializes a
PartiallySignedTransaction, into two functions: DecodeBase64PSBT, which
retains the old behavior, and DecodeRawPSBT, which only performs the
deserialization.

Add a test for base64 decoding failure.

Partial backport of core PR14978:
https://github.com/bitcoin/bitcoin/pull/14978/commits/c734aaa15d924470cec0f17b00ad2e47472b471f

Depends on D5736.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 15 2020, 15:46