Page MenuHomePhabricator
Differential D5740

Factor out combine / finalize / extract PSBT helpers
ClosedPublic
Actions

Authored by Fabien on Apr 15 2020, 13:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING082a077015c7: Factor out combine / finalize / extract PSBT helpers
rABC082a077015c7: Factor out combine / finalize / extract PSBT helpers
Summary
Refactor the new CombinePSBT, FinalizePSBT, and FinalizeAndExtractPSBT
general-purpose functions out of the combinepsbt and finalizepsbt RPCs,
for use in the GUI code.

Completes backport of core PR14978:
https://github.com/bitcoin/bitcoin/pull/14978/commits/102faad81efa1cb12c29c466cfe81fc8c7351e1d

Depends on D5739.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14978_part7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10232
Build 18288: Default Diff Build & Tests
Build 18287: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2020, 13:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2020, 13:10
teamcity edited the summary of this revision. (Show Details)Apr 15 2020, 13:10

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 15 2020, 13:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 15 2020, 13:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10232: Diff 18828.Apr 15 2020, 13:22
deadalnix accepted this revision.Apr 15 2020, 15:42
This revision is now accepted and ready to land.Apr 15 2020, 15:42
Closed by commit rABC082a077015c7: Factor out combine / finalize / extract PSBT helpers (authored by Glenn Willen <gwillen@nerdnet.org>, committed by Fabien). · Explain WhyApr 16 2020, 13:58
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC082a077015c7: Factor out combine / finalize / extract PSBT helpers.
Fabien added a commit: rSTAGING082a077015c7: Factor out combine / finalize / extract PSBT helpers.May 5 2020, 18:59

Revision Contents
Changeset List

PathSize
src/
node/
1 line
2 lines
34 lines
51 lines
rpc/
46 lines
2 lines

Diff 18828

View Options

src/node/transaction.h

Loading...
View Options

src/node/transaction.cpp

Loading...
View Options

src/psbt.h

Loading...
View Options

src/psbt.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/util.cpp

Loading...