Page MenuHomePhabricator

[tools] Add wallet inspection and modification tool
ClosedPublic

Authored by deadalnix on Apr 17 2020, 01:15.

Details

Summary

This commit adds wallet-tool, a tool for creating and interacting with
wallet files. Original implementation was by Jonas Schnelli
<dev@jonasschnelli.ch> with modifications by John Newbery
<john@johnnewbery.com>

  • [tests] Add wallet-tool test

Original tests by João Barbosa <joao.paulo.barbosa@gmail.com>

Additional contribution by John Newbery <john@johnnewbery.com>

This is a backport of Core PR13926

Depends on D5749 and D5750

Test Plan
./test/functional/test_runner.py tool_wallet.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13926
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10259
Build 18340: Default Diff Build & Tests
Build 18339: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Apr 17 2020, 09:55
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/CMakeLists.txt
16

?

src/bitcoin-wallet-res.rc
2

"clientversion.h" => <clientversion.h>

4

There is no CLIENT_VERSION_BUILD

src/bitcoin-wallet.cpp
59

Core => ABC

96

braces

136

braces

test/functional/tool_wallet.py
73

Why are these values different from core ?

This revision now requires changes to proceed.Apr 17 2020, 09:55
src/CMakeLists.txt
16

Having options in the same order in various places is good.

test/functional/tool_wallet.py
73

There certainly are difference of behavior in the way the key pool is managed and also segwit addresses.

Fabien added inline comments.
src/CMakeLists.txt
16

OK with the idea, but I don't know what other place you're talking about. It used to be consistent with their use order in this file, can you point me to where it is different ?

This revision is now accepted and ready to land.Apr 17 2020, 13:21
src/CMakeLists.txt
16

autotool