Page MenuHomePhabricator
Differential D5778

init: Remove deprecated args from hidden args
ClosedPublic
Actions

Authored by Fabien on Apr 20 2020, 12:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGd37a92f211f8: init: Remove deprecated args from hidden args
rABCd37a92f211f8: init: Remove deprecated args from hidden args
Summary
The args have been deprecated since 0.17 (maybe longer) and since we
reject unknown args, there is no need to add deprecated args to the list
of hidden args and then hand-craft an error message if a user provides
them.

Backport of core PR14272.

Test Plan
arc lint --everything

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14272
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10302
Build 18425: Default Diff Build & Tests
Build 18424: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 20 2020, 12:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2020, 12:08
teamcity edited the summary of this revision. (Show Details)Apr 20 2020, 12:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 20 2020, 12:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added a child revision: D5779: Refactor: Replace fprintf with tfm::format.Apr 20 2020, 12:14
teamcity added a comment.Apr 20 2020, 12:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10302: Diff 18945.Apr 20 2020, 12:19
deadalnix accepted this revision.Apr 20 2020, 14:32
This revision is now accepted and ready to land.Apr 20 2020, 14:32
Closed by commit rABCd37a92f211f8: init: Remove deprecated args from hidden args (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyApr 20 2020, 15:11
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd37a92f211f8: init: Remove deprecated args from hidden args.
Fabien removed a child revision: D5779: Refactor: Replace fprintf with tfm::format.Apr 20 2020, 15:21
Fabien added a commit: rSTAGINGd37a92f211f8: init: Remove deprecated args from hidden args.May 5 2020, 19:03

Revision Contents
Changeset List

PathSize
src/
5 lines
7 lines
37 lines
test/
lint/
10 lines

Diff 18945

View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/httpserver.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

test/lint/check-doc.py

Loading...