Page MenuHomePhabricator
Differential D5779

Refactor: Replace fprintf with tfm::format
AbandonedPublic
Actions

Authored by Fabien on Apr 20 2020, 12:14.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Summary
This should be a refactor except in the cases where we use the wrong
format specifier, in which case this patch is a bug fix.

Backport of core PR16205.

This allows to reenable the fprintf detection in the locale dependence
linter.

Depends on D5776 and D5778.

Test Plan
arc lint --everything

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16205
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10304
Build 18429: Default Diff Build & Tests
Build 18428: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 20 2020, 12:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2020, 12:14
teamcity edited the summary of this revision. (Show Details)Apr 20 2020, 12:14

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 20 2020, 12:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10303: Diff 18946.Apr 20 2020, 12:37
teamcity added a comment.Apr 20 2020, 12:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien updated this revision to Diff 18958.Apr 20 2020, 15:21

Rebase

Fabien removed parent revisions: D5776: Enable PID file creation on WIN, D5778: init: Remove deprecated args from hidden args.Apr 20 2020, 15:21
teamcity added a comment.Apr 20 2020, 15:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox accepted this revision.Apr 20 2020, 15:55
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/tinyformat.h
1089

Nit: comment style should be:

/**
 * stuff...
 */
This revision is now accepted and ready to land.Apr 20 2020, 15:55
teamcity added a comment.Apr 20 2020, 15:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10304: Diff 18958.Apr 20 2020, 15:59
deadalnix added a subscriber: deadalnix.Apr 20 2020, 17:24

There are a ton of callsites missing. Check

grep -r ../src/ -e fprintf | grep -v leveldb | grep -v secp256k1 | grep -v univalue

deadalnix requested changes to this revision.Apr 20 2020, 17:24
This revision now requires changes to proceed.Apr 20 2020, 17:24
deadalnix mentioned this in D5782: Refactor: Replace fprintf with tfm::format.Apr 20 2020, 17:53
Fabien abandoned this revision.Apr 20 2020, 18:06

Superseded by D5782 (add the seeder to the changes)

Revision Contents
Changeset List

PathSize
arcanist/
linter/
4 lines
src/
bench/
8 lines
25 lines
19 lines
30 lines
38 lines
7 lines
2 lines
qt/
2 lines
28 lines
2 lines
util/
12 lines
wallet/
72 lines
test/
lint/
1 line

Diff 18958

View Options

arcanist/linter/LocaleDependenceLinter.php

Loading...
View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/bitcoin-wallet.cpp

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/noui.cpp

Loading...
View Options

src/qt/utilitydialog.cpp

Loading...
View Options

src/sync.cpp

Loading...
View Options

src/tinyformat.h

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/wallet/wallettool.cpp

Loading...
View Options

test/lint/lint-format-strings.py

Loading...